maiao: easy, Gerrit-style, stacked diffs workflow for GitHub
4 points by joaoqalves
4 points by joaoqalves
where each commit becomes its own PR.
Well that's weird. And also I guess we get to find out if GitHub's pull_request_id is an int64
In the spirit of being constructive, a feedback that I gave Graphite is that in these stacked PR setups it's very hard to reason about the end result of applying them, which isn't true of a normal PR's diff view. I'm certainly open to pushback of "you're holding it wrong" but as the reviewer I have limited influence over the behavior of other people
Not weird at all: It's good practice to split commits the way it's possible to individually merge and review them. And bad not to squash the fix into the breakage. This makes your history bisectable. If this is in any way important, the diff view is the wrong way to review anyway, as it misses this.