Surviving Code Reviews in the era of AI

81 points by mrpossoms


My coworkers are all fully AI pilled. As a consequence, every PR that comes my way for review is on average ~6k lines of diff.

It's well established that even PRs an order of magnitude smaller than this are too big to be effectively reviewed. I'm still clinging to the idea that us humans should understand how the systems we are building work, so I'm hesitant to use AI for reviews aside from more general question answering. Much of what it produces in the way of explanations are difficult to follow and overly verbose anyway.

I'm sure I'm not the only person here who has been dealing with this problem, so I'm curious if anyone here has found any strategies (organizational or personal) which have helped weather this maelstrom.

wmoxam

6k diffs are completely unreviewable, and would be rejected in our workplace. We have rules that PRs with diffs cannot be > 400 lines (with exceptions for things like moving code). These rules apply if the code is produced by AI or humans, there is no difference between the two.

We use AI PR reviews, but only as a first pass in order to save human reviewers some time.

IMO AI tools are useful but they are just that, tools. The code produced and decisions made are still the responsibility of the people using the tools. Ex: AI isn't capable of deciding if code is good enough to ship.